Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(goreleaser): missing tendermint->cometbft update #3083

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix(goreleaser): missing tendermint->cometbft update #3083

merged 1 commit into from
Apr 25, 2024

Conversation

tbruyelle
Copy link
Contributor

This one escaped the migration, probably because it's located in a hidden file.

Note that this omission does not seem to have affected the releases that followed the migration (at least for v15.0.2, which is the only one I've checked), as cometbft.TMCoreSemVer is already equal to the correct version (it's apparently updated manually during the cometbft release process).

@tbruyelle
fix(goreleaser): missing tendermint->cometbft update
53f8970 
This one escaped the migration, probably because it's located in a
hidden file.

Note that this omission does not seem to have affected the releases that
followed the migration (at least for v15.0.2, which is the only one I've
checked), as `cometbft.TMCoreSemVer` is already equal to the correct
version (it's apparently updated manually during the cometbft release
process).
MSalopek
MSalopek approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

I think there's a line missing when you run gaiad version --long, there's no other impact on the system.

LGTM.

@tbruyelle
Copy link
Contributor Author

Thanks for your contribution!

I think there's a line missing when you run gaiad version --long, there's no other impact on the system.

LGTM.

Hey thank you @MSalopek
I think the affected command is more likely gaiad cometbft version, but as mentioned in the PR body, TMCoreSemVer is manually set to the correct version during the cometbft release process, so actually, there is no impact at all (until someone forgets to do that update ;)).

@MSalopek
Copy link
Contributor

Thanks for your contribution!
I think there's a line missing when you run gaiad version --long, there's no other impact on the system.
LGTM.

Hey thank you @MSalopek I think the affected command is more likely gaiad cometbft version, but as mentioned in the PR body, TMCoreSemVer is manually set to the correct version during the cometbft release process, so actually, there is no impact at all (until someone forgets to do that update ;)).

Thanks for the clarification.

For completeness:

$: gaiad cometbft version
ABCI: 1.0.0
BlockProtocol: 11
P2PProtocol: 8
Tendermint: 0.37.5

@mpoke mpoke merged commit 848f8f4 into cosmos:main Apr 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoke mpoke mpoke approved these changes

@MSalopek MSalopek MSalopek approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@zmanian zmanian Awaiting requested review from zmanian zmanian is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@jackzampolin jackzampolin Awaiting requested review from jackzampolin jackzampolin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbruyelle @MSalopek @mpoke